Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit Numpy and Scipy requirements #412

Merged
merged 6 commits into from
Feb 2, 2023

Conversation

AmintorDusko
Copy link
Contributor

Context: PennyLane is a hard dependence and already provides Numpy and Scipy as requirements.

Description of the Change: Remove explicit Numpy and Scipy dependence

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #412 (1ce2596) into master (7a14f88) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          49       49           
  Lines        4463     4463           
=======================================
  Hits         4458     4458           
  Misses          5        5           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AmintorDusko AmintorDusko marked this pull request as ready for review February 2, 2023 15:51
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmintorDusko for putting these together.

@AmintorDusko AmintorDusko changed the title Remove explicit Numpy and Scipy dependence Remove explicit Numpy and Scipy requirement Feb 2, 2023
@AmintorDusko AmintorDusko changed the title Remove explicit Numpy and Scipy requirement Remove explicit Numpy and Scipy requirements Feb 2, 2023
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @AmintorDusko , thanks!

@AmintorDusko AmintorDusko merged commit f02becc into master Feb 2, 2023
@AmintorDusko AmintorDusko deleted the update/numpy_dependence branch February 2, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants